javascript - jQuery Refactoring - DRY -


i have these 2 functions, inside of main function. you'll see difference between 2 of them in middle how append/edit html. thinking nice come 2 new functions, 1 first half , other second half. i'm not sure if possible jquery, or javascript matter, don't know how call these new functions inside of these functions, if makes sense. help/guidance great!

here first one

$('#save').click(function(){ var title = $('#title').val(); var tags = $('#tags').val(); var notes = $('#notes').val(); var mydate = new date(); if (title.length < 1) {   $('.title-warn').show(); } if (tags.length < 1) {   $('.tags-warn').show(); } if (notes.length < 1) {   $('.notes-warn').show(); } if (title.length >= 1 && tags.length >= 1 && notes.length >= 1) {   $allnotes.prepend('<li class="note"><div><h1>' + title + '</h1><div class="date">      <h2>'+ mydate.todatestring() +'</h2><span class="btn btn-edit">edit</span></div><h3>' + tags + '</h3><p>' + notes + '</p></div></li>');   $allnotes.show();   $newnote.hide();   $('.title-warn').hide();   $('.tags-warn').hide();   $('.notes-warn').hide(); } $('#title').val(''); $('#tags').val(''); $('#notes').val(''); $('#search').prop('disabled', false); $('#search').attr("placeholder", "search title, tags, date, or words/sentences in notes"); $('.btn-search').prop('disabled', false); });

and second one

$('#edit').click(function(){ var title = $('#edit-title').val(); var tags = $('#edit-tags').val(); var notes = $('#edit-notes').val(); var mydate = new date(); if (title.length < 1) {   $('.title-warn').show(); } if (tags.length < 1) {   $('.tags-warn').show(); } if (notes.length < 1) {   $('.notes-warn').show(); } if (title.length >= 1 && tags.length >= 1 && notes.length >= 1) {   $('.edited-note').html('<div><h1>' + title + '</h1><div class="date">      <h2>'+ mydate.todatestring() +'</h2><span class="btn btn-edit">edit</span></div><h3>' + tags + '</h3><p>' + notes + '</p></div>');   $('.allnotes').show();   $('.edit-note').hide();   $('.title-warn').hide();   $('.tags-warn').hide();   $('.notes-warn').hide(); } $('#title').val(''); $('#tags').val(''); $('#notes').val(''); $('#search').prop('disabled', false); $('#search').attr("placeholder", "search title, tags, date, or words/sentences in notes"); $('.btn-search').prop('disabled', false); $('.edited-note').removeclass('edited-note'); });

and of course if has suggestions on other aspects of code criticism!

you answered own question! "as you'll see difference between 2 of them in middle how append/edit html." initial pretty naive , mechanical attempt attempt @ refactoring might this, pulling out common code shared functions:

function prehandler(title, tags, notes) {     if (title.length < 1) {         $('.title-warn').show();     }     if (tags.length < 1) {         $('.tags-warn').show();     }     if (notes.length < 1) {         $('.notes-warn').show();     }      return title.length >= 1 && tags.length >= 1 && notes.length >= 1;  }   function commonpost () {      $('#title').val('');     $('#tags').val('');     $('#notes').val('');     $('#search').prop('disabled', false);     $('#search').attr("placeholder", "search title, tags, date, or words/sentences in notes");     $('.btn-search').prop('disabled', false);   }    $('#save').click(function(){     var title = $('#title').val();     var tags = $('#tags').val();     var notes = $('#notes').val();     var mydate = new date();     if  (prehandler(title, tags, notes)) {          $allnotes.prepend('<li class="note"><div><h1>' + title + '</h1><div class="date">      <h2>'+ mydate.todatestring() +'</h2><span class="btn btn-edit">edit</span></div><h3>' + tags + '</h3><p>' + notes + '</p></div></li>');         $allnotes.show();         $newnote.hide();         $('.title-warn').hide();         $('.tags-warn').hide();         $('.notes-warn').hide();      }     commonpost();  });   $('#edit').click(function() {     var title = $('#edit-title').val();     var tags = $('#edit-tags').val();     var notes = $('#edit-notes').val();     var mydate = new date();      if  (prehandler(title, tags, notes)) {          $('.edited-note').html('<div><h1>' + title + '</h1><div class="date">      <h2>'+ mydate.todatestring() +'</h2><span class="btn btn-edit">edit</span></div><h3>' + tags + '</h3><p>' + notes + '</p></div>');         $('.allnotes').show();         $('.edit-note').hide();         $('.title-warn').hide();         $('.tags-warn').hide();         $('.notes-warn').hide();      }      commonpost();     $('.edited-note').removeclass('edited-note');  });

it doesn't win when there 2 scenarios. more 2 doing sort of refactoring starts reap rewards.

this first attempt refined (a lot). perhaps nice folks post. first attempt.


-

Comments

Post a Comment

Popular posts from this blog

facebook - android ACTION_SEND to share with specific application only -

in android application have 4 buttons facebook , viber , telegram , whatsapp , want share different content based on each button. for example if user clicks on viber button want user action_send share content viber only. i found this explains how facebook , twitter seems it's calling specific class name of application don't know applications wanna use except facebook. all android apps have unique id, first have check if these apps installed in user's device , can pass unique id via intent sharing. according below: unique ids different apps : viber : com.viber.voip telegram : org.telegram.messenger whatsapp : com.whatsapp check if these apps installed , if installed send messages through intent. private void sendmessage(context context,string message, string appids) { final boolean isappinstalled =isappavailable(context, appids); if (isappinstalled) { intent myintent = new intent(intent.action_send); myintent.settype("text/p...
Read more

python - Creating a new virtualenv gives a permissions error -

i'm getting following output when running virtualenv newvenv . traceback (most recent call last): file "/usr/local/bin/virtualenv", line 5, in <module> pkg_resources import load_entry_point file "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 2727, in <module> add_activation_listener(lambda dist: dist.activate()) file "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 700, in subscribe callback(dist) file "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 2727, in <lambda> add_activation_listener(lambda dist: dist.activate()) file "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 2227, in activate self.insert_on(path) file "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 2334, in insert_on self.check_version_conflict() file "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 2373, in check_version_conflict...
Read more

javascript - cocos2d-js draw circle not instantly -

i wondering how draw circles (or other shapes also) not instantly. so far tried drawcircle(args...) in ccdrawnode.js , drawcircle(args...) in cc.drawingprimitivecanvas class, , draw circles popping out instantly on screen. what if want achieve effect circular progressive bar, completes circle based on percentage of initialization? or more generally, if want draw circle respect prolonged period? thinking there drawcircle function elapsed time argument fail find any. or have implement own? thanks suggestions, far out of ideas. i think have implement own. think can achieve update circle drawing on each time update() function called.
Read more